-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register QML modules at build time + use qmlcachegen #649
Conversation
6bb58d2
to
156277c
Compare
470f313
to
9591272
Compare
I removed the qml_extension_plugin example now that this is automatically generating QML plugins under the hood. If the user wants a dynamically linked QML extension plugin, that can easily be created by specifying |
686cc14
to
4c69d3a
Compare
I wonder if we should still have an example somewhere of using the crate-type as Maybe it doesn't need to be explicitly called extension plugin, but instead dynamic linking or something. Although would this be for cargo-only builds ? For a CMake example where one is dynamic linking would you just create a CMake library and static link the Rust into that as normal ? |
A cdylib QML plugin example could be for either Cargo-only or CMake builds. With CMake, the cdylib generated by Cargo would be linked into the C++ executable. |
Lets instead document this in the book :-) |
It will be redundant when we automatically generate a QML module at build time.
This is a prerequisite for using qmlcachegen KDAB#242
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets start with this and any refactors of qt-build-utils etc can be later.
Awesome work getting the QML modules to build correctly and removing the qrc files 🎉 🥳
Fixes #242