register QML elements at build time #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
qml_element
branch
6 times, most recently
from
8fd1360 to
bd9019b
Compare
|
The trick to getting static QML plugin registration working with the Unfortunately this only works when Cargo links the executable though. CMake has an analogous WHOLE_ARCHIVE feature, but when I tried to use it like: linking failed because the static library includes duplicate symbols: If there was a way to somehow pass the path of the |
Be-ing
force-pushed
the
qml_element
branch
8 times, most recently
from
c0ead97 to
8e72555
Compare
|
It turns out the duplicate symbol errors before were because some C++ files were getting compiled twice and linked twice. 🙃 So it is possible to link with Somehow this caused #110 to affect a few more tests on macOS 🤷 It also triggers what seems to be a bug in valgrind in a few tests on Ubuntu, which I can't reproduce locally on Fedora 37. |
Thanks for shaving this yak, this is really impressive! 🦀 Ironically, cxx-qt is now even better than the official Qt cmake API, as this is now also working for Qt5. 🎉 (i.e. at least the fully declarative type declaration, not sure if qmltc and qmlsc will also be possible) |
Checking for the presence of the qmltc executable and using it conditionally would be easy. qmlcachegen exists with Qt5 as well. |
vimpostor
requested changes
Feb 8, 2023
Be-ing
force-pushed
the
qml_element
branch
2 times, most recently
from
a0acc8f to
bcac4ed
Compare
LeonMatthesKDAB
requested changes
Feb 8, 2023
Be-ing
force-pushed
the
qml_element
branch
3 times, most recently
from
fea483d to
b0ebd28
Compare
by specifying [cxxqt::qobject(qml_uri = "foo.bar", qml_verison = "1.0")] Fixes KDAB#241
to avoid C++ symbol name collisions if more than one qrc file is used
so rust-analyzer can make use of the error during macro expansion
|
I'd like to add a C++ generation test in cxx-qt-gen, but I don't see how to write the output files? Is there a tool for this somewhere that I'm missing? |
No, unfortunately not, the easiest way is to start with an empty file, which is gonna give you the complete diff to what is currently being generated. We should probably work on such a tool at some point though, that just updates the test_output files. |
3 tasks
How about adding that in another PR? |
Of course, shouldn't be part of this PR. |
|
Ready to merge then? |
LeonMatthesKDAB
approved these changes
Feb 9, 2023
vimpostor
approved these changes
Feb 9, 2023
Be-ing
added a commit
to Be-ing/cxx-qt
that referenced
this pull request
Feb 9, 2023
Follow up to KDAB#428
Be-ing
added a commit
to Be-ing/cxx-qt
that referenced
this pull request
Feb 9, 2023
Follow up to KDAB#428
Be-ing
added a commit
to Be-ing/cxx-qt
that referenced
this pull request
Feb 9, 2023
Follow up to KDAB#428
ahayzen-kdab
pushed a commit
to Be-ing/cxx-qt
that referenced
this pull request
Feb 13, 2023
Follow up to KDAB#428
przempore
pushed a commit
to przempore/cxx-qt
that referenced
this pull request
Mar 15, 2023
Follow up to KDAB#428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by specifying
#[cxxqt::qobject(qml_uri = "foo.bar", qml_verison = "1.0")]TODO: