build cxx-qt-lib autogenerated C++ with Cargo instead of CMake #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
from
50628a6
to
de5dc13
Compare
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
16 times, most recently
from
841c4e0
to
c62afff
Compare
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
9 times, most recently
from
8d62528
to
39c2bdd
Compare
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
ahayzen-kdab
reviewed
Aug 1, 2022
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
2 times, most recently
from
4028c85
to
ed4b8e8
Compare
ahayzen-kdab
force-pushed
the
cxx-qt-lib_cxx-build
branch
from
ed4b8e8
to
f4c6349
Compare
ahayzen-kdab
requested changes
Aug 2, 2022
There was a problem hiding this comment.
Hmm i think we either need to fix the locking issue or find a workaround, it's failure rate is too high to accept even for a flaky temporary thing.
I guess possible solutions are
- Add a commit to use cargo workspaces in this branch
- Let rust wait / keep trying until it's successful in copying the file
- Tell CMake to not run the execute_process in parallel to other CMake tasks
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
3 times, most recently
from
a7fd284
to
4229d9f
Compare
ahayzen-kdab
reviewed
Aug 2, 2022
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
4 times, most recently
from
9aded7f
to
82d5875
Compare
This is intended to be shared between build.rs scripts regardless of whether cc, cpp_build, or cxx_build is used.
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
from
82d5875
to
1fb23b5
Compare
This is a step towards obviating the need for CMake to build autogenerated code, which will simplify the build process by moving the invocation of Cargo to CMake build time rather than CMake configure time.
Be-ing
force-pushed
the
cxx-qt-lib_cxx-build
branch
from
1fb23b5
to
39823a3
Compare
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as proposed