-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build cxx-qt-lib autogenerated C++ with Cargo instead of CMake #174
Conversation
50628a6
to
de5dc13
Compare
841c4e0
to
c62afff
Compare
8d62528
to
39c2bdd
Compare
4028c85
to
ed4b8e8
Compare
ed4b8e8
to
f4c6349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm i think we either need to fix the locking issue or find a workaround, it's failure rate is too high to accept even for a flaky temporary thing.
I guess possible solutions are
- Add a commit to use cargo workspaces in this branch
- Let rust wait / keep trying until it's successful in copying the file
- Tell CMake to not run the execute_process in parallel to other CMake tasks
a7fd284
to
4229d9f
Compare
9aded7f
to
82d5875
Compare
This is intended to be shared between build.rs scripts regardless of whether cc, cpp_build, or cxx_build is used.
82d5875
to
1fb23b5
Compare
This is a step towards obviating the need for CMake to build autogenerated code, which will simplify the build process by moving the invocation of Cargo to CMake build time rather than CMake configure time.
1fb23b5
to
39823a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
as proposed