This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
Activity Report print fixes #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charm does not include the last day of the range, tough to change this it should be heavily refactored
happened that the user name gets forgotten and the report generates with an empty name. if it's empty, the one taken from the user table takes precedence Why a cached value of the user name is needed in metadata in the first place?
previous and next links should never be in the printed report. move them to external push buttons
need to fit very long text in the comments, use a normal flow with a <p>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Charm and Activity report (printing as PDF) internally in the company and had several issues with it: