Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic devel #268

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Noetic devel #268

wants to merge 18 commits into from

Conversation

oscar-lima
Copy link
Collaborator

@oscar-lima oscar-lima commented Nov 9, 2020

changes for ROSPlan to run in noetic

@harshkakashaniya
Copy link

Great Work Oscar.
For making ROSplan work for noetic.
Is something missing because the build is breaking?

@oscar-lima
Copy link
Collaborator Author

Great Work Oscar.
For making ROSplan work for noetic.
Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy
I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

@harshkakashaniya
Copy link

You are right !!!
There are some warnings while it is been build.
But it is working fine on my PC.
Thank you ...

@harshkakashaniya
Copy link

Dear oscar,
I had a question for you.
can we add negative conditions in our problem file ?

Planner is not able to plan if I have a negative condition in problem file.
for example:
(not (docked kenney))

does not work ..

any solutions.

@DerekLong101
Copy link

DerekLong101 commented Jan 15, 2021 via email

@harshkakashaniya
Copy link

Dear Derek,
Thank you very much for your detailed answer and export preaching.
now I understood the thinking behind this.
Everything makes much more sense now.

Regards,
Harsh

@harshkakashaniya
Copy link

I am having issues with the sensing interface:

File "/home/hbk_il/Desktop/Integrated_ws/src/integratedcore/ROSPlan/rosplan_sensing_interface/scripts/sensing_interface.py", line 285
def subs_callback(self, msg, (pred_name, pred_info)):
^
SyntaxError: invalid syntax
[rosplan_sensing_interface-7] process has died [pid 137784, exit code 1, cmd /home/hbk_il/Desktop/Integrated_ws/src/integratedcore/ROSPlan/rosplan_sensing_interface/scripts/sensing_interface.py __name:=rosplan_sensing_interface __log:=/home/hbk_il/.ros/log/a6dfdcea-6122-11eb-b76b-13b46bf4b6f3/rosplan_sensing_interface-7.log].
log file: /home/hbk_il/.ros/log/a6dfdcea-6122-11eb-b76b-13b46bf4b6f3/rosplan_sensing_interface-7*.log

@gerardcanal
Copy link
Contributor

Hi @harshkakashaniya,
I just opened a PR #277 to address the issue with the sensing interface. This will fix the issue you're experiencing, and it's due to Noetic using Python 3.

@oscar-lima oscar-lima closed this Apr 26, 2021
@oscar-lima oscar-lima reopened this Apr 26, 2021
oscar-lima and others added 3 commits April 27, 2021 10:15
remove unused import that does not work with python3
Update ROSPlanProblemViewer.py
@YanielCarreno
Copy link

Great Work Oscar.
For making ROSplan work for noetic.
Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

Hi @oscar-lima ,

Thanks for the noetic extension. I also faced problems building ROSPlan for noetic. I fixed it by adding -Wno-error in [1] in the rosplan_dependencies CMakeList.

[1] SET (RDDL_CMAKE_CXX_FLAGS "${RDDL_CMAKE_CXX_FLAGS} -g -Wall -W -Wno-sign-compare -Wno-deprecated -ansi -pedantic -Werror -std=c++11 -O3 -DNDEBUG -fomit-frame-pointer -Wno-error=deprecated-copy")

@ViniciusAbrao
Copy link

Great Work Oscar.
For making ROSplan work for noetic.
Is something missing because the build is breaking?

The problem is: cc1plus: error: -Werror=deprecated-copy: no option -Wdeprecated-copy I introduced a workaround which works on my PC, however it does not seem to work on the integration server, you can try on your PC, maybe you are lucky

Hi @oscar-lima ,

Thanks for the noetic extension. I also faced problems building ROSPlan for noetic. I fixed it by adding -Wno-error in [1] in the rosplan_dependencies CMakeList.

[1] SET (RDDL_CMAKE_CXX_FLAGS "${RDDL_CMAKE_CXX_FLAGS} -g -Wall -W -Wno-sign-compare -Wno-deprecated -ansi -pedantic -Werror -std=c++11 -O3 -DNDEBUG -fomit-frame-pointer -Wno-error=deprecated-copy")

Tks for this !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants