Build error on mac, related to boost libraries

[arinabykadorova]

This occurred while building Kass inside of the Locust software, forked here. I was compiling from source on my mac (Mojave 10.14.6).

[  1%] Building CXX object Kommon/CMakeFiles/Kommon.dir/Gsl/Utility/KGslErrorHandler.cxx.o 
In file included from /Users/arinabtelles/locust_mc/kassiopeia/Kommon/Gsl/Utility/KGslErrorHandler.cxx:8:
In file included from /usr/local/include/boost/stacktrace.hpp:15:
In file included from /usr/local/include/boost/stacktrace/frame.hpp:20:
In file included from /usr/local/include/boost/stacktrace/safe_dump_to.hpp:217:
/usr/local/include/boost/stacktrace/detail/collect_unwind.ipp:33:2: error: "Boost.Stacktrace requires _Unwind_Backtrace function.
      Define _GNU_SOURCE macro or BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED if _Unwind_Backtrace is available without
      _GNU_SOURCE."
#error "Boost.Stacktrace requires _Unwind_Backtrace function. Define _GNU_SOURCE macro or BOOST_STACKTRACE_GNU_SOURCE_...
 ^
1 error generated.
make[5]: *** [Kommon/CMakeFiles/Kommon.dir/Gsl/Utility/KGslErrorHandler.cxx.o] Error 1
make[4]: *** [Kommon/CMakeFiles/Kommon.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [src/KassiopeiaExt-stamp/KassiopeiaExt-build] Error 2
make[1]: *** [CMakeFiles/KassiopeiaExt.dir/all] Error 2
make: *** [all] Error 2 

After doing some research, I was able to fix it by adding these lines right after line 102 of kassiopeia/Kommon/CMakeLists.txt:

if(UNIX OR APPLE OR MINGW)
    target_compile_definitions(Kommon PRIVATE _GNU_SOURCE)
endif()

I'm not entirely sure what the role of _GNU_SOURCE is in the build, but this seems to work. Is this a valid workaround? What is the cause of the build error? Thanks!

[arinabykadorova]

Note, I found the fix at the bottom of the comments at this link: boostorg/stacktrace#88

[pslocum]

Thanks for checking this. Can we also try to build standalone Kassiopeia v3.8.0 as in https://github.com/KATRIN-Experiment/Kassiopeia or https://github.com/project8/kassiopeia/tree/feature/v3.8.0 ? This would be the latest version.

…

On Tue, Oct 19, 2021 at 3:24 PM arinabykadorova ***@***.***> wrote: Note, I found the fix at the bottom of the comments at this link: boostorg/stacktrace#88 <boostorg/stacktrace#88> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBROK7NICAIUAL6TRT6ZLUHXAWJANCNFSM5GJ4OV2A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[arinabykadorova]

Trying it just from the the main Kass branch on https://github.com/KATRIN-Experiment/Kassiopeia, I get the same behavior - same error and same fix works.

[zykure]

Thanks for reporting this! I think the workaround is fine. I'll add it to the CMake config.