Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharma - Improve item descriptions on inventory #574

Conversation

Apricot-ale
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Apricot-ale
Copy link
Contributor Author

Apricot-ale commented Aug 2, 2024

Should be rewrite other language... done

<Finnish>Pitää sinut hereillä</Finnish>
<Russian>Не дает тебе уснуть</Russian>
<English>Stimulates the central nervous system and energizes</English>
<Japanese>中枢神経を刺激し、活力を与える</Japanese>
Copy link
Contributor Author

@Apricot-ale Apricot-ale Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an idea to use
<English>Reduce fatigue, regain and boost stamina</English>
but this can be turned on and off in the settings, right?
For now, we decided on words that emphasize immersion.

use my German and French friend and my brain and chatGPT so if it's wrong, remove or rewrite line pls.
@MiszczuZPolski MiszczuZPolski added this to the 2.15.1 milestone Aug 3, 2024
@ItsGiantCookie
Copy link

ItsGiantCookie commented Aug 6, 2024

I looked over the German text, it needs some work, it's directly translated which doesn't make sense.

For instance:

anesthetic analgesic
Anästhetikum-Analgetikum

In German those 2 Word mean very diffrent things and don't work as a compound word.

@Apricot-ale
Copy link
Contributor Author

I looked over the German text, it needs some work, it's directly translated which doesn't make sense.

For instance:

anesthetic analgesic
Anästhetikum-Analgetikum

In German those 2 Word mean very diffrent things and don't work as a compound word.

That's absolutely true.
I checked again, and everything except for opioids seems unnatural. (well, opioid is too but better)
It would be better to delete them for now.
(Someone will probably translate them later...)

 (except English and Japanese)
Remove "analgesic" word because it's weird.
Copy link
Collaborator

@MiszczuZPolski MiszczuZPolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would remove translations other than english, japanese and polish (they look quite okay) and leave its translations to contributors

@MiszczuZPolski MiszczuZPolski added the area/translations Release Notes: **TRANSLATIONS:** label Aug 8, 2024
@MiszczuZPolski MiszczuZPolski merged commit 49d173f into KAT-Advanced-Medical:dev-Tomcat Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translations Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants