Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc - Add Full Body Stiching #494

Merged
merged 34 commits into from
Apr 1, 2024
Merged

Misc - Add Full Body Stiching #494

merged 34 commits into from
Apr 1, 2024

Conversation

Belhun
Copy link
Contributor

@Belhun Belhun commented Mar 6, 2024

When merged this pull request will:

  • Reintroduce Full Body Stitching to the medical menu, using scripts adapted from an older version of ACE. This adaptation occurs after the HashMap introduction and before the shift to per-body-part stitching.
  • Ensure compatibility of the old stitching scripts within KAT medical systems.
  • Add actions to ACE_Medical_Treatment_Actions to support Full Body Stitching. Currently, two actions are defined; the first is temporarily commented out to debug issues related to operation time discrepancies.
    Things To Still Do:
  • Remove Comment out debugging Code
  • Fixing stitching is not on a Timer
  • Add Setting Toggleing Fullbody Stitching

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MiszczuZPolski MiszczuZPolski added this to the 2.14.0 milestone Mar 6, 2024
@MiszczuZPolski MiszczuZPolski added the kind/feature request Release Notes: **ADDED:** label Mar 6, 2024
@Belhun
Copy link
Contributor Author

Belhun commented Mar 8, 2024

ToDo:

  • Change Nameing Structure of Functions and English Translations From "Full Body Stitching" to "Stitching Full Body"

@Belhun
Copy link
Contributor Author

Belhun commented Mar 9, 2024

Allright! Am considering this Ready to go, nothing Else i can think of to Add. welll actually am gonna fix the Order in Prep, cause now its bothering me since i changed the names of the funcions

addons/misc/ACE_Medical_Treatment_Actions.hpp Outdated Show resolved Hide resolved
addons/misc/stringtable.xml Outdated Show resolved Hide resolved
addons/misc/stringtable.xml Outdated Show resolved Hide resolved
@Belhun
Copy link
Contributor Author

Belhun commented Mar 21, 2024

Is there anything anything else I need to do to improve this?

@MissHeda
Copy link
Contributor

Did you test it ingame yet?

@Belhun
Copy link
Contributor Author

Belhun commented Mar 21, 2024

Did you test it ingame yet?

Yes, i did. The feature works as intended. The setting is also working.

@MiszczuZPolski MiszczuZPolski modified the milestones: 2.14.0, 2.14.1 Apr 1, 2024
@MiszczuZPolski MiszczuZPolski merged commit b244f43 into KAT-Advanced-Medical:dev-Tomcat Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature request Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants