Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical - Fix mortar issues #458

Merged

Conversation

MiszczuZPolski
Copy link
Collaborator

When merged this pull request will:

  • Fix wrong inheritance
  • Fix "No matching carry mag" that was blocking unloading 8rnd and 5rnd ammo from mortar

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MiszczuZPolski MiszczuZPolski added the kind/cleanup Release Notes: **FIXED:** label Dec 23, 2023
@MiszczuZPolski MiszczuZPolski added this to the 2.14.0 milestone Dec 23, 2023
@Apricot-ale Apricot-ale mentioned this pull request Jan 23, 2024
Copy link
Contributor

@AtrixZockt AtrixZockt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I did but it seems my pr was rigged or something but for me these changes worked when I did them few months ago

@diaverso
Copy link

This not fix
https://i.imgur.com/ZuvJSei.jpeg

@MiszczuZPolski
Copy link
Collaborator Author

This not fix https://i.imgur.com/ZuvJSei.jpeg

Yes, i know there are still some issues but i dont have time to search for solutions.

@MissHeda MissHeda modified the milestones: 2.14.0, Ongoing Mar 3, 2024
};

class ACE_mortar_82mm: mortar_82mm {
magazines[] = {"ACE_1Rnd_82mm_Mo_HE","ACE_1Rnd_82mm_Mo_Smoke","ACE_1Rnd_82mm_Mo_Illum","ACE_1Rnd_82mm_Mo_HE_Guided","ACE_1Rnd_82mm_Mo_HE_LaserGuided", "KAT_1Rnd_82mm_Mo_Type0", "KAT_1Rnd_82mm_Mo_TypeCS"};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
magazines[] = {"ACE_1Rnd_82mm_Mo_HE","ACE_1Rnd_82mm_Mo_Smoke","ACE_1Rnd_82mm_Mo_Illum","ACE_1Rnd_82mm_Mo_HE_Guided","ACE_1Rnd_82mm_Mo_HE_LaserGuided", "KAT_1Rnd_82mm_Mo_Type0", "KAT_1Rnd_82mm_Mo_TypeCS"};
magazines[] += {"KAT_1Rnd_82mm_Mo_Type0", "KAT_1Rnd_82mm_Mo_TypeCS"};

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as it is because it ends up being only these two

@MiszczuZPolski MiszczuZPolski modified the milestones: Ongoing, 2.15.0 Apr 25, 2024
@MiszczuZPolski MiszczuZPolski added kind/bug fix Release Notes: **FIXED:** and removed kind/cleanup Release Notes: **FIXED:** labels Apr 25, 2024
@MiszczuZPolski MiszczuZPolski merged commit d251601 into KAT-Advanced-Medical:dev-Tomcat Apr 25, 2024
3 checks passed
@MiszczuZPolski MiszczuZPolski deleted the chemicalMortar branch July 24, 2024 16:44
@nobodyshome
Copy link

nobodyshome commented Aug 4, 2024

Somehow this change has broken/effected the L16 static weapon from 3CB weapons

Removed recently updated mods one by one till it worked as intended and it worked after disabling KAT.

When working, info is described as the "L16 Static Weapon" with "Charge 0" and "81mm HE/Smoke", the charges go up to "Charge 6"

with KAT v2.15.0, it reverts the mortar to just "82mm Mortar" and has "Semi (close)" "Semi (medium)" and "Semi (far)". Believe whatever changes were made regarding this issue may be the cause. Can test and help debug if required.

@MiszczuZPolski
Copy link
Collaborator Author

Please contact on discord and create bug thread on it, so its easier to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants