Skip to content

Commit

Permalink
fix: version definition order in formula generation
Browse files Browse the repository at this point in the history
  • Loading branch information
Justintime50 committed Jan 12, 2024
1 parent f21d26b commit 392a242
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: extractions/setup-just@v1
- uses: actions/setup-python@v4
with:
Expand All @@ -27,7 +27,7 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: extractions/setup-just@v1
- uses: actions/setup-python@v4
with:
Expand All @@ -36,7 +36,7 @@ jobs:
brew-audit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: extractions/setup-just@v1
- uses: Homebrew/actions/setup-homebrew@master
# These Homebrew packages are needed since we have them as fake dependencies for some test output
Expand All @@ -47,7 +47,7 @@ jobs:
docker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: '3.12'
Expand All @@ -57,7 +57,7 @@ jobs:
if: github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: extractions/setup-just@v1
- uses: actions/setup-python@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## v0.18.1 (2024-01-12)

- Corrects order of `version` definition in formula generation to satisfy the ever-changing Homebrew audit rules

## v0.18.0 (2023-12-12)

- Adds a `version` parameter which can override the automatically detected version of a formula with an explicit value
Expand Down
2 changes: 1 addition & 1 deletion homebrew_releaser/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.18.0'
__version__ = '0.18.1'
2 changes: 1 addition & 1 deletion homebrew_releaser/formula.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ class {{class_name}} < Formula
desc "{{description}}"
homepage "https://github.com/{{owner}}/{{repo_name}}"
url "{{tar_url}}"{{# download_strategy}}, using: {{download_strategy}}{{/ download_strategy}}
sha256 "{{autogenerated_tar_checksum}}"
{{# version}}
version "{{version}}"
{{/ version}}
sha256 "{{autogenerated_tar_checksum}}"
{{# license_type}}
license "{{license_type}}"
{{/ license_type}}
Expand Down
2 changes: 1 addition & 1 deletion test/formulas/test_generate_formula_override_version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ class TestGenerateFormulaOverrideVersion < Formula
desc "Release scripts, binaries, and executables to github"
homepage "https://github.com/Justintime50/test-generate-formula-override-version"
url "https://github.com/Justintime50/test-generate-formula-override-version/archive/refs/tags/v0.1.0.tar.gz"
sha256 "0000000000000000000000000000000000000000000000000000000000000000"
version "9.8.7"
sha256 "0000000000000000000000000000000000000000000000000000000000000000"
license "MIT"

def install
Expand Down

0 comments on commit 392a242

Please sign in to comment.