[BREAKING] Investigate possibility of moving to System.Text.Json #3061
Labels
💣 Breaking changes
Issues marked with this label indicate possible breaking changes that might need major version bump.
✨ Enhancement
Issues marked with this label indicate further enhancements to the program, such as new features.
🟢 Low priority
Issues marked with this label are actively being worked on if nothing serious is on the list.
🙏 Wishlist
Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Comments
JustArchi
added
✨ Enhancement
JustArchi
added
⛔ On hold
JustArchi
changed the title
JustArchi
removed
the
⛔ On hold
JustArchi
added
🟢 Low priority
JustArchi
added a commit
that referenced
this issue
Feb 21, 2024
* Good start * Misc * Make ApiAuthenticationMiddleware use new json * Remove first newtonsoft dependency * Pull latest ASFB json enhancements * Start reimplementing newtonsoft! * One thing at a time * Keep doing all kind of breaking changes which need to be tested later * Add back ShouldSerialize() support * Misc * Eradicate remaining parts of newtonsoft * WIP * Workaround STJ stupidity in regards to derived types STJ can't serialize derived type properties by default, so we'll use another approach in our serializable file function * Make CI happy * Bunch of further fixes * Fix AddFreeLicense() after rewrite * Add full support for JsonDisallowNullAttribute * Optimize our json utilities even further * Misc * Add support for fields in disallow null * Misc optimization * Fix deserialization of GlobalCache in STD * Fix non-public [JsonExtensionData] * Fix IM missing method exception, correct db storage helpers * Fix saving into generic databases Thanks STJ * Make Save() function abstract to force inheritors to implement it properly * Correct ShouldSerializeAdditionalProperties to be a method * Misc cleanup * Code review * Allow JSON comments in configs, among other * Allow trailing commas in configs Users very often add them accidentally, no reason to throw on them * Fix confirmation ID Probably needs further fixes, will need to check later * Correct confirmations deserialization * Use JsonNumberHandling * Misc * Misc * [JsonDisallowNull] corrections * Forbid [JsonDisallowNull] on non-nullable structs * Not really but okay * Add and use ToJson() helpers * Misc * Misc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Checklist
Enhancement purpose
As a first pre-step, I've migrated ASFB to System.Text.Json a few months ago and it's working fine without any issues or drawbacks. ASF will likely need more work due to the fact that the codebase is much bigger, but it should be viable with only limited amount of missing functionalities such as
Required = Required.DisallowNull.Solution
Why currently available solutions are not sufficient?
Can you help us with this enhancement idea?
Yes, I can code the solution myself and send a pull request
Additional info
No response
The text was updated successfully, but these errors were encountered: