Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the hardcoded ip address with a dns lookup #1

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

MabezDev
Copy link
Contributor

I can't actually test that it works because my ISP is having issue right now 🙃.

I can test at least that the error handling works :D.

For my router I also needed to bump the number of DNS servers smoltcp has capacity for with:

# .cargo/config.toml
[env]
SMOLTCP_DNS_MAX_SERVER_COUNT = "3"

Be warned that you have to do a clean build for those changes to take effect, see: rust-lang/cargo#10358

Copy link
Owner

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! Also works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants