Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jobState.getEntity in favor of jobState.findEntity #306

Closed
austinkelleher opened this issue Aug 24, 2020 · 0 comments
Closed

Remove jobState.getEntity in favor of jobState.findEntity #306

austinkelleher opened this issue Aug 24, 2020 · 0 comments
Assignees
@austinkelleher
Labels
breaking Will require a major version enhancement New feature or request

Comments

@austinkelleher
Copy link
Contributor

Related: #284

jobState.findEntity is now the preferred approach. We should remove getEntity.
@austinkelleher austinkelleher added the enhancement New feature or request label Aug 24, 2020
@austinkelleher austinkelleher self-assigned this Aug 24, 2020
@austinkelleher austinkelleher added the breaking Will require a major version label Aug 24, 2020
austinkelleher added a commit that referenced this issue Aug 24, 2020
@austinkelleher
Merge pull request #307 from JupiterOne/306-remove-getEntity
92ef77c 
Fixes #306 - Remove `jobState.getEntity` in favor of `jobState.findEn…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinkelleher austinkelleher

Labels
breaking Will require a major version enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austinkelleher