Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-15732 - Add validation for labels field #132

Merged
merged 1 commit into from
Nov 1, 2024
Merged

APP-15732 - Add validation for labels field #132

merged 1 commit into from
Nov 1, 2024

Conversation

jzolo22
Copy link
Member

@jzolo22 jzolo22 commented Oct 18, 2024

QA Checklist

Alerts Rule Packs

  • IF THIS CONTENT NEEDS TO BE RELEASED - is the package version in the package.json bumped?
  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@jzolo22 jzolo22 marked this pull request as ready for review October 18, 2024 19:12
@jzolo22 jzolo22 requested a review from a team as a code owner October 18, 2024 19:12
@SeaBlooms SeaBlooms merged commit 54ac5ca into main Nov 1, 2024
9 checks passed
@SeaBlooms SeaBlooms deleted the APP-15732 branch November 1, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-willis ryan-willis ryan-willis approved these changes

@SeaBlooms SeaBlooms SeaBlooms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzolo22 @SeaBlooms @ryan-willis