This repository was archived by the owner on Sep 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
APP-15551 - Updating integration to prep for integration helpers #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzolo22
commented
Jul 3, 2024
@@ -174,7 +182,17 @@ export class ServicesClient { | |||
{ retryAfter }, | |||
`Received a rate limit error. Waiting before retrying.`, | |||
); | |||
await sleep(retryAfter); | |||
sleep(retryAfter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently handleError
doesn't accept functions that return promises. Not sure how this was working with async/await
before 🤔
ryan-willis
approved these changes
Jul 3, 2024
Will release together with createIntegrationHelper updates once those are completed |
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.map
functions intoiteratee
functions