Add location attribute to managed device resource and data sources
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopalans
approved these changes
Dec 8, 2024
chrismarget-j
deleted the
970-add-support-for-location-attribute-to-apstra_managed_device-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
locationattribute to the following:apstra_managed_deviceresourceapstra_agentdata sourceapstra_agentsdata sourceReading the
locationdata from the API requires making an extra API call because the "managed device" concept is split into two Apstra objects: agent and system. "system" is the one with the "location" field. It is created as a side-effect of creating the agent, so it must be managed under a single declarative resource.The
Acknowledge()applies a "user config" struct to the agent; this has the side effect of "acknowledging" the device. But now we're also sending the location field (part of the user config), soAcknowledge()has been renamed toSetUserConfig()to better reflect it's behavior.Other errata:
returnon error