Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant plan.GetSystemAttributes() call in resourceDeviceAllocation.Update() #939

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Remove redundant plan.GetSystemAttributes() call in resourceDeviceAllocation.Update() #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apstra/resource_datacenter_device_allocation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,14 +308,11 @@ func (o *resourceDeviceAllocation) Update(ctx context.Context, req resource.Upda
return
}

// read back any apstra-assigned attributes
// read back any apstra-assigned attributes; copy them to the state
plan.GetSystemAttributes(ctx, bp, &resp.Diagnostics)
if resp.Diagnostics.HasError() {
return
}

// read and save any apstra-assigned values
plan.GetSystemAttributes(ctx, bp, &resp.Diagnostics)
state.SystemAttributes = plan.SystemAttributes

// copy the deploy mode to the deprecated root-level attribute
Expand Down
Loading