Support virtual network resource without bindings; Improve config version constraints #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate config constraints from `apiversions` to `compatibility` - convert constraint objects from hashicorp's to chrismarget-j's - eliminate obsolete version constraints (4.1.x-specific and >= 4.2.0 stuff) - add 5.x version constraint for VN with no bindings
chrismarget-j
changed the title
bwJuniper
approved these changes
Oct 14, 2024
chrismarget-j
deleted the
912-allow-vn-creation-with-no-bindings-when-apstra-5x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started life as the simple (HA!) task of dropping the requirement for VN bindings with Apstra 5.0.0.
Then things got hairy.
The full scope of the damage:
nullbinding set is only valid with Apstra 5.x. The existing config validation scheme relies onConstraintsfrom thegithub.com/hashicorp/go-versionpackage... Which don't work with Apstra's non-semver versioning strategy. The config validation scheme has been migrated from theapiversionspackage to thecompatibilitypackage, and now usesConstraintsfrom thegithubub.com/chrismarget-j/version-constraintspackage.bindingsattribute has been changed fromRequiredtoOptional. ASizeAtLeast(1)validator remains, so it's not permitted to specify an empty binding set.Read(). We prevent state churn by wiping out those bindings when none are present in the state. This required exporting theVnBinding.AttrTypes()method.apstra_datacenter_virtual_networkhas been rewritten to current style.Tests are passing with 4.2.0, 4.2.1, 4.2.1.1, 4.2.2, 5.0.0
Closes #912
Closes #920