Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TestCfgFileToEnv() for testing w/out valid TLS certificate #905

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Improve TestCfgFileToEnv() for testing w/out valid TLS certificate #905

merged 1 commit into from
Oct 4, 2024

Conversation

chrismarget-j
Copy link
Collaborator

This PR:

  • adds tls_validation_disabled (boolean) attribute to .testconfig.hcl file
  • changes function signature of TestCfgFileToEnv() so that it takes a testing.TB and no longer returns error
  • improves environmental setup with t.SetEnv()
  • adds a call to TestCfgFileToEnv() to the problem test in TLS failures in test TestResourceDatacenterRack() #904

Closes #904

@chrismarget-j chrismarget-j linked an issue Oct 4, 2024 that may be closed by this pull request
TLS failures in test TestResourceDatacenterRack() #904
Closed
@chrismarget-j chrismarget-j merged commit 2b7548c into main Oct 4, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the 904-tls-failures-in-test-testresourcedatacenterrack branch October 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwJuniper bwJuniper bwJuniper approved these changes

@rajagopalans rajagopalans Awaiting requested review from rajagopalans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS failures in test TestResourceDatacenterRack()
2 participants
@chrismarget-j @bwJuniper