Disable resource apstra_blueprint_iba_dashboards with 5.x.x #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
requested review from
rajagopalans and
bwJuniper
and removed request for
rajagopalans
bwJuniper
approved these changes
Sep 25, 2024
chrismarget-j
deleted the
871-add-version-checking-to-disable-data-source-apstra_blueprint_iba_dashboards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding the validation checks, I removed the configuration fetch from
dataSourceBlueprintIbaDashboard.ValidateConfig().It turns out, we don't need the actual config when we're interested only in checking the API version.
We know the config exists because we entered that function. That fact, combined with the API version is enough to detect a problem. No need to fetch the actual configuration.
Closes #871