Fix 404 handling in apstra_datacenter_connectivity_template_assignments resource
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
force-pushed
the
bug/764-missing-return
branch
from
d55da5c to
09d3dad
Compare
bwJuniper
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After handling 404 response via
resp.State.RemoveResource(),resourceDatacenterConnectivityTemplateAssignments.Read()should return cleanly to allow Terraform to plan re-creation of the missing resource.The return isn't there, leading terraform to surface a handle-able error to the user.
Closes #764
cc: @michaelbhughes