Audit tag validation #751
Merged
Audit tag validation #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways to express "none of something" in HCL:
and
In Terraform, these are distinct values, but most of our API endpoints don't distinguish between an empty set and a null set, making it tricky for us to avoid state churn by getting the correct value (
nullor[]) into the Terraform state.The easiest way to police it is to just disallow one of the values.
This PR is the result of auditing the tag set on all resources and data sources to ensure that we (a) handle empty sets correctly in resources and (b) disallow empty tag values.
Closes #736