Task/749 **BREAKING CHANGE** - Change IPv6 role strings in apstra_datacenter_resource_pool_allocation
resource
#750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the set of valid strings for the
apstra_datacenter_resource_pool_allocation
resource'srole
attribute.The following strings have been replaced for consistency with the many other valid values which put
ipv6
at the end:ipv6_spine_leaf_link_ips
-------->spine_leaf_link_ips_ipv6
ipv6_spine_superspine_link_ips
->spine_superspine_link_ips_ipv6
ipv6_to_generic_link_ips
--------->to_generic_link_ips_ipv6
After upgrading to a provider release which includes this change, the terraform provider will no longer accept the old strings. A validation error will require the configuration to be amended to use these new values.
After the configuration has been updated to use the new values, Terraform will plan a change, but the change should be nondisruptive to the blueprint. Notice this resource is being updated in-place, and the only attribute subject to change is
role
:Details of what's in this PR:
role
attribute'sRequiresReplace
plan modifier has been changed toRequiresReplaceIf
with a helper function which recognizes the old and new strings: No replace when updatingrole
from an old style value to a new style value.rosetta
module required to bring the new values to lifeapstra.InterfaceNumberingIpv4Type
andapstra.InterfaceNumberingIpv6Type
which were required to get the rosetta tests passingCloses #749