Fix path matching in AtLeastProductOfValidator.Validate()
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwJuniper
approved these changes
Jul 25, 2024
chrismarget-j
deleted the
bug/745-fix-path-matching-in-at-least-n-of-validator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtLeastProductOfValidator.Validate()was incorrectly assuming that passed paths would be relative to the root attribute, rather than relative to the attribute being validated.This PR introduces
req.PathExpression.MergeExpressions(o.PathExpression)along with a loop to handle the results which should resolve the issue.Need to exercise the behavior in each of the bgp-related data sources to make sure it still works as expected.The validator is confirmed working in each of these:
apstra_datacenter_ct_bgp_peering_generic_systemapstra_datacenter_ct_bgp_peering_ip_endpointapstra_datacenter_ct_dynamic_bgp_peering