735 review #740
Merged
735 review #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
changed the base branch from
main
to
735-freeform-resource-datasource-for-resource-allocation-groups
bwJuniper
approved these changes
Jul 23, 2024
bwJuniper
merged commit ea0cc3e
into
735-freeform-resource-datasource-for-resource-allocation-groups
1 check passed
chrismarget-j
deleted the
735-freeform-resource-datasource-for-resource-allocation-groups-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor string massaging here.
Biggest change: I ripped out
tagsbecause I don't see it in the web UI.Also, we should chat about the name:
ravs.resource_allocationraat all... is this merely a "Resource Group" in the UI?choosing between API attributes and Web UI presentation is tricky...