Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce env_var_prefix provider configuration attribute #728

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Introduce env_var_prefix provider configuration attribute #728

merged 5 commits into from
Jul 17, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Jul 17, 2024 •
edited
Loading

This PR:

  • introduces the env_var_prefix provider configuration attribute
  • moves constants for APSTRA_* environment variables to the constants package
  • renames those constants to remove "apstra" from their name: envApstraUrl -> envUrl
  • reorganizes the constants package a bit: separate files for errors, numeric, environment

Closes #727

@chrismarget-j chrismarget-j merged commit b511d31 into main Jul 17, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the feat/727-env-var-prefix branch July 17, 2024 22:16
@chrismarget-j chrismarget-j mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwJuniper bwJuniper bwJuniper approved these changes

@rajagopalans rajagopalans Awaiting requested review from rajagopalans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add env_prefix attribute to provider configuration block
2 participants
@chrismarget-j @bwJuniper