Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 handling in apstra_datacenter_ip_link_addressing resource #704

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

chrismarget-j
Copy link
Collaborator

No description provided.

@chrismarget-j chrismarget-j changed the base branch from main to rename-ip-links-ids-attribute July 10, 2024 18:55
@rajagopalans
Copy link
Collaborator

I am unsure why we are removing the resource if the read finds no blueprint, but not if the update finds no blueprint.
We should do the same in either case right?

@chrismarget-j
Copy link
Collaborator Author

I am unsure why we are removing the resource if the read finds no blueprint, but not if the update finds no blueprint. We should do the same in either case right?

RemoveResource() has no effect in Update().

There's a short window during plan and apply where the required object could have been deleted, but there's no graceful way of handling an impossible-to-execute plan. It's going to be an error.

@rajagopalans
Copy link
Collaborator

I am unsure why we are removing the resource if the read finds no blueprint, but not if the update finds no blueprint. We should do the same in either case right?

RemoveResource() has no effect in Update().

There's a short window during plan and apply where the required object could have been deleted, but there's no graceful way of handling an impossible-to-execute plan. It's going to be an error.

Sounds good.

@chrismarget-j chrismarget-j changed the base branch from rename-ip-links-ids-attribute to main July 11, 2024 15:25
@chrismarget-j chrismarget-j merged commit f5350e9 into main Jul 11, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the ip-links-handle-404 branch July 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants