device_allocation resource: check if the target is switch or server inUpdate()
#590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EnsureSystemIsSwitchBeforeCreate()function gets called to ensure that the target system is a switch (not generic) before adevice_allocationresource withsystem_attributesis allowed toCreate().That is because servers have different methods for handling ASN and Loopback addressing then switches, and we've only implemented the switch bits.
The problem comes up if a user adds
system_attributesafter initial create.We need to do the same check in
Update().This PR renames
EnsureSystemIsSwitchBeforeCreate()toEnsureSystemIsSwitch()and modifies its check to use either theNodeNameattribute (during initialCreate()) orNodeId(duringUpdate()) as appropriate.