Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #144: Suppress API error on 404 #145

Merged
merged 4 commits into from
Jun 14, 2023
Merged

bug #144: Suppress API error on 404 #145

merged 4 commits into from
Jun 14, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Jun 14, 2023

resource apstra_interface_map triggers multiple diagnostics when encountering a 404 while fetching device profile or logical device.

This PR ensures that only the "not found" or the API error is surfaced to the user and fixes #144.

apstra/resource_interface_map.go Outdated Show resolved Hide resolved
@chrismarget-j chrismarget-j merged commit 94fe1e3 into main Jun 14, 2023
@chrismarget-j chrismarget-j deleted the bug/144 branch June 14, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect 404 error handling in resource apstra_interface_map
2 participants