Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta update #12

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Rosetta update #12

merged 6 commits into from
Apr 11, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Apr 10, 2023 •
edited
Loading

This PR is built on #11, which should be merged first. It is intended to close #68 from the old repo.

  • Adds apstra.RefDesign (iota) support to rosetta and rosetta tests.
  • Uses the new rosetta support in data_source_blueprints.go to replace a point solution for: 'datacenter' vs. 'two_stage_l3clos'
  • Remove rosetta strings which don't get translated.
  • Make rosetta string constants private (they're not being used outside of the utils package)

chrismarget-j and others added 2 commits April 10, 2023 19:26
@chrismarget-j
use new rosetta capability in data_source_blueprints.go
ccbde38
@rajagopalans
Merge pull request #14 from Juniper/main
b618621 
Merge pull request #11 from Juniper/resource-managed-device-refactoring
@rajagopalans rajagopalans merged commit 6b4d909 into main Apr 11, 2023
@rajagopalans rajagopalans deleted the rosetta-update branch April 11, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajagopalans rajagopalans rajagopalans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismarget-j @rajagopalans