Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider renaming apstra_datacenter_blueprint_system_node -> apstra_datacenter_system #97

Closed
chrismarget-j opened this issue May 23, 2023 · 3 comments
Assignees

Comments

@chrismarget-j
Copy link
Collaborator

Data source apstra_datacenter_blueprint_system_nodes returns a list of graph node IDs of system nodes.
Data source apstra_datacenter_blueprint_system_node returns detailed info about a single system node.

We'll likely be creating a bunch of data sources that follow this pattern. Currently in queue are data sources for routing_zones/routing_zone and virtual_networks/virtual_network.

Are the words blueprint and node really helping much here?

Should they instead be:

  • apstra_datacenter_systems
  • apstra_datacenter_system
  • apstra_datacenter_routing_zones
  • apstra_datacenter_routing_zone
  • apstra_datacenter_virtual_networks
  • apstra_datacenter_virtual_network
@rajagopalans
Copy link
Collaborator

My vote is for apstra_datacenter_* apstra_datacenter_blueprint* seems a little extra

@chrismarget-j
Copy link
Collaborator Author

When I first created the system/systems data source it was a big departure from the others: Totally graph-query based.

This felt like a big departure...

But it's really only relevant to me as the implementer. I don't think the end user needs to know this level of detail.

@chrismarget-j
Copy link
Collaborator Author

Fixed by #104. Thank you @bwJuniper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants