Resource virtual network support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes needed to support Virtual Network objects in Terraform.
!!!! Breaking Change !!!!
QEQueryis now an interface. The original object, which fulfills the interface has been renamedPathQuery.!!!! Breaking Change !!!!
The
SetContext()is method is no longer part of the formerQEQueryobject nor any implementations of the new `QEQuery interface.!!!! Breaking Change !!!!
The
QEQuery.Do()method now takes a context (it's no longer "set" in advance, as noted above).There are new two implementations of the
QEQueryinterface:PathQuery, which is the oldQEQueryobject, andMatchQuery, which supports the logical AND of multiple queries using the Apstra Query Engine'smatchsyntax.Down the road I'd like to deprecate the
Client.NewQuery()method because nowQEQueryobjects don't necessarily needclientandblueprintIdelements populated (these are handled by the parent query in thematchcase. This PR introduces theSetBlueprint()andSetClient()methods with that in mind (previously those elements were set in byNewQuery()with no way of reaching them.Finally, this PR introduces some VirtualNetwork iota helper functions which follow the usual pattern.