[Mellanox] Add bitmap support for SFP error event #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Apr 18, 2021
1. Update get_change_event
- Return event in a bitmap format in case there is an error
- Return an extra map indexed by sfp_error in case there is a Mellanox-specific error
- Indicate whether the error is a blocking error
2. Expose the error status of SFP modules to CLI
- A platform API calls SDK API to fetch the error status
- Display the SFP module state: plugged, unplugged and plugged with error.
- The SFP error state is displayed only if the SFP module state is plugged with error
- The CLI will call platform API and provide user-friendly output
3. Redirect stderr to /dev/null in order to eliminate errors in case SFP module is not plugged
4. Beautify the code, making all the state/error/descriptions defined in a uniform place
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Support handling the error status of SFP modules
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Nov 25, 2021
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (#91) 07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (#89) 47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (#90) ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (#87) 6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (#85) d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (#68) 8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (#78) fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (#82) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
May 11, 2022
[master][sonic-linkmgrd] submodule updates df51322 Longxiang Lyu Fri May 6 10:01:46 2022 +0800 Add `ActiveActiveStateMachine` implementation (#64) e721ceb Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (#63) 7bb06fb Jing Zhang Tue May 3 09:48:28 2022 -0700 Add Cli support to enable or disable default route related feature (#68) e4b02cb Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (#70) 212d960 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (#69) 48abc9e Jing Zhang Thu Apr 14 16:50:04 2022 -0700 Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (#61) c4858a6 Jing Zhang Thu Apr 14 11:27:55 2022 -0700 Avoid proactively switching to `active` if default route is missing (#62) sign-off: Jing Zhang zhangjing@microsoft.com
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jun 25, 2023
…e latest HEAD automatically (sonic-net#15016) src/wpasupplicant/sonic-wpa-supplicant * a24412c25 - (HEAD -> 202205, origin/master, origin/HEAD, origin/202211, origin/202205, master) [mka]: Fix unexpected cleanup (#73) (8 days ago) [Ze Gan] * 26d1da0bc - [mka]: Fix re-establishment by reset MI (#72) (8 days ago) [Ze Gan] * f07e0a097 - [azp]: Update build pipeline to build for Bullseye (#70) (4 weeks ago) [Ze Gan] * 2c69e2cda - Use github code scanning instead of LGTM (#69) (6 months ago) [Liu Shilong] |\ | * 23abb04e5 - fix (6 months ago) [shilongliu] | * f34d68fe6 - libdbus-1-dev (6 months ago) [shilongliu] | * dc2dd881e - add dbus (6 months ago) [shilongliu] | * 5de037661 - use swsscommon packages (6 months ago) [shilongliu] | * 32c5a2729 - Use github code scanning instead of LGTM (6 months ago) [shilongliu] |/ * aa731b96f - [azp]: Install libyang in azure pipeline (#68) (8 months ago) [Hua Liu] * 71b635d74 - Revert "[Azp]: Upgrade Azp to bullseye (#49)" (#66) (9 months ago) [Ze Gan] * 7aa4e6fa4 - Adding Microsoft SECURITY.MD (#58) (9 months ago) [microsoft-github-policy-service[bot]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)