[system-health] Add fan direction check for system health #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Apr 4, 2023
| expect_fan_direction = direction | ||
| elif direction != expect_fan_direction: | ||
| self.set_object_not_ok('Fan', name, | ||
| f'{name} direction is wrong, expect:{expect_fan_direction}, got:{direction}') |
There was a problem hiding this comment.
I suppose in this case we can only say that one fan's direction is not matched with the previously checked fan's direction, we can say not all fan's directions are aligned, but can not say which fan's direction is expected.
keboliu
approved these changes
Apr 4, 2023
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 14, 2023
sonic-net#15576) #### Why I did it src/linkmgrd ``` * fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (#184) (2 hours ago) [Jing Zhang] * 5c6332d - Re-handle pre-init mux config notification after state machine init (#202) (2 hours ago) [Longxiang Lyu] * c49a5ef - [active-standby][bsl] fix no mux probe issue (#201) (2 hours ago) [Jing Zhang] * 2d62ef1 - Enable debug symbols (#199) (2 hours ago) [Longxiang Lyu] * f952b64 - [active-active] Add mux server state correction mechanism (#191) (2 hours ago) [Longxiang Lyu] * e6b1bfc - [ci] fix azure pipeline (#190) (2 hours ago) [Jing Zhang] * 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (#184) (2 hours ago) [Jing Zhang] * 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (#179) (2 hours ago) [Jing Zhang] * 6fb9a0b - loose link down swithcover condition (#178) (2 hours ago) [Jing Zhang] * 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (#177) (2 hours ago) [Liu Shilong] * 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first. (#175) (2 hours ago) [Jing Zhang] * 68c06d9 - [active-active] Toggle to standby if default route is missing (#171) (2 hours ago) [Longxiang Lyu] * 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (#169) (2 hours ago) [Jing Zhang] * a96105f - Fix the warning of unused variables (#167) (2 hours ago) [Longxiang Lyu] * 984ffe3 - Fix mux config when gRPC connection is lost (#166) (2 hours ago) [Longxiang Lyu] * 4d0b457 - [active-active] force switch when config == active && target state == active (#164) (2 hours ago) [Jing Zhang] * 32bd2bb - Use github code scanning instead of LGTM (#157) (2 hours ago) [Liu Shilong] * 6f23fe2 - [active-active] update linkmgr health label definition (#163) (3 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add fan direction check to system health, all fans should be in the same direction
How I did it
Add fan direction check to system health, all fans should be in the same direction
How to verify it
Manual test
Unit test
Need add sonic-mgmt test case to verify
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)