Disable nagles alg #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @c42f have you found time to take a look at this? |
Add a bunch of potential error messages in "troubleshooting.md"
This ensures it's in a standard section of the docs and will be built with the rest of the docs.
|
Thanks for getting around to it. I know you are busy with other important stuff. I am pretty sure I was watching you live on the Juliacon stage when I wrote the previous comment xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54.
This PR adds a single line to disable nagles algorithm, using the
Sockets.naglefunction. This is done on the client side, inside thesetup_connection!function.On my system, the effect is that
@btime @remote 1+1goes from 44.5 ms to 0.601 ms, or a 74x speedup. As the operation itself (1+1) takes 1.4 ns, we can say we are approximately timing the overhead. So in other words, the overhead of calls to@remoteis reduced 74-fold.I have made no changes to any documentation, and I have not performed any more than a single test. I am not sure if we should expect this to break anything, as the change is rather minor. Testing was done on Julia 1.9.3.