Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added https #25

Closed
wants to merge 1 commit into from
Closed

added https #25

wants to merge 1 commit into from

Conversation

dioptre
Copy link

@dioptre dioptre commented Feb 21, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 52.13%

Merging #25 into master will increase coverage by +0.32% as of 615af13

@@            master     #25   diff @@
======================================
  Files            7       7       
  Stmts          110     117     +7
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             57      61     +4
  Partial          0       0       
- Missed          53      56     +3

Review entire Coverage Diff as of 615af13

Powered by Codecov. Updated on successful CI builds.

@MikeInnes
Copy link
Collaborator

Thanks for the patch, glad to have this although I think it could be simplified a little (will leave a note).

MikeInnes
MikeInnes reviewed Feb 22, 2016
View reviewed changes
src/server.jl

function serve(s::Server, port = default_port)
@async @errs run(s, port)
function serve(s::Server; args...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like using serve(s::Server, port = 8000; ssl = nothing) would simplify this PR quite a bit.

amellnik pushed a commit to amellnik/Mux.jl that referenced this pull request Apr 17, 2018
@malmaud
Merge pull request JuliaWeb#25 from JuliaWeb/jm/bindata
363c134 
Represent payloads as byte arrays
amellnik pushed a commit to amellnik/Mux.jl that referenced this pull request Apr 17, 2018
@IainNZ
Merge pull request JuliaWeb#25 from JuliaWeb/nohttp
cf992f3 
URIParser doesn't depend on HttpCommon
@cmcaine cmcaine mentioned this pull request Dec 20, 2020
Open
18 tasks
@cmcaine
Copy link
Collaborator

cmcaine commented Sep 5, 2023

Closing. Mux has changed enough that if we ever support HTTPS, we will have to write a new PR.

@cmcaine cmcaine closed this Sep 5, 2023
@cmcaine
Copy link
Collaborator

cmcaine commented Sep 5, 2023

Lol, I forgot that we already support HTTPS. Check the tests for example use. An even better reason to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dioptre @codecov-io @MikeInnes @cmcaine