Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secrets API #178

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Support secrets API #178

merged 2 commits into from
Dec 10, 2020

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Dec 10, 2020

Closes #159

No tests because doing anything with secrets requires authentication. But I used it to successfully create a DOCUMENTER_KEY secret for any of my personal repos that lacked it.

Copy link
Collaborator

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the other exported functions like secrets and delete_secret should be in the README.

@timholy
Copy link
Collaborator Author

timholy commented Dec 10, 2020

I could add them. Right now it seems a bit hit-or-miss:

julia> rdme = read("README.md", String);

julia> let yes = no = 0
           for name in names(GitHub)
               if occursin(string(name), rdme)
                   yes += 1
               else
                   no += 1
               end
           end
           println("yes: ", yes)
           println("no: ", no)
       end
yes: 118
no: 16

But since the large majority appear, I'll add it and then merge this.

@timholy timholy merged commit dac95a3 into master Dec 10, 2020
@timholy timholy deleted the teh/secrets branch December 10, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function to add a secret
2 participants