Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Commit

Permalink
Require Git_jll v2.31 and Julia v1.6 (#42)
Browse files Browse the repository at this point in the history
  • Loading branch information
giordano authored Mar 21, 2021
1 parent 195ab94 commit 415a759
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 9 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.3'
- '1'
- '^1.6.0-0'
- 'nightly'
os:
- ubuntu-latest
Expand All @@ -35,7 +34,7 @@ jobs:
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v2
env:
cache-name: cache-artifacts
with:
Expand Down
7 changes: 5 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
name = "GitCommand"
uuid = "49b5b516-ca3f-4003-a081-42bdcf55082d"
authors = ["Dilum Aluthge", "Brown Center for Biomedical Informatics"]
version = "2.0.0"
version = "2.1.0"

[deps]
JLLWrappers = "692b3bcd-3c85-4b1f-b108-f13ce0eb3210"
Git_jll = "f8c6e375-362e-5223-8a59-34ff63f689eb"
ReplMaker = "b873ce64-0db9-51f5-a568-4457d8e49576"

[compat]
JLLWrappers = "1.1"
Git_jll = "2.31"
ReplMaker = "0.2.3"
julia = "1.3"
julia = "1.6"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
1 change: 1 addition & 0 deletions src/GitCommand.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module GitCommand

import JLLWrappers
import Git_jll
import ReplMaker

Expand Down
8 changes: 4 additions & 4 deletions src/env.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ function _env_mapping(; adjust_PATH::Bool = true,
if haskey(ENV, "PATH")
env_mapping["PATH"] = ENV["PATH"]
end
if haskey(ENV, Git_jll.LIBPATH_env)
env_mapping[Git_jll.LIBPATH_env] = ENV[Git_jll.LIBPATH_env]
if haskey(ENV, JLLWrappers.LIBPATH_env)
env_mapping[JLLWrappers.LIBPATH_env] = ENV[JLLWrappers.LIBPATH_env]
end
return git_path, env_mapping
end
Expand All @@ -28,7 +28,7 @@ function _env_mapping(; adjust_PATH::Bool = true,
share_git_core_templates = joinpath(share_git_core, "templates")

libcurlpath = dirname(Git_jll.LibCURL_jll.libcurl_path)
originallibpath = get(ENV, Git_jll.LIBPATH_env, "")
originallibpath = get(ENV, JLLWrappers.LIBPATH_env, "")
newlibpath = "$(libcurlpath)$(sep)$(originallibpath)"

ssl_cert = joinpath(dirname(Sys.BINDIR), "share", "julia", "cert.pem")
Expand All @@ -37,7 +37,7 @@ function _env_mapping(; adjust_PATH::Bool = true,
env_mapping["GIT_EXEC_PATH"] = libexec_git_core
env_mapping["GIT_SSL_CAINFO"] = ssl_cert
env_mapping["GIT_TEMPLATE_DIR"] = share_git_core_templates
env_mapping[Git_jll.LIBPATH_env] = newlibpath
env_mapping[JLLWrappers.LIBPATH_env] = newlibpath
if haskey(ENV, "PATH")
env_mapping["PATH"] = ENV["PATH"]
end
Expand Down

9 comments on commit 415a759

@giordano
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giordano This is the first release since we moved to a new org.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I've installed Registrator on this org.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Changing package repo URL not allowed, please submit a pull request with the URL change to the target registry and retry.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/32495

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.1.0 -m "<description of version>" 415a7599511ef4aae4616f756d8a12908066f2f1
git push origin v2.1.0

Please sign in to comment.