Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yh/multi color visualizer #140

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

yijiangh
Copy link
Collaborator

Summary

This is a long overdue PR on the continuum and truss visualizers.

Highlights:

  1. multi-cell color support for both visualizers
  2. fix Visualizer not displaying supports for problems parsed from .inp files #137
  3. fix Visualization of first documentation example #99

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

This PR is only related to visualizer, which is not covered by unit tests for now.

  • I ran all tests on my computer and it's all green (i.e. ] test).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@yijiangh
Copy link
Collaborator Author

@mohamed82008 I am sorry that this commit history is messy. I started working on this a while back and got busy with other stuff. Recently, when I got back on this, I merged from master and kept developing. I am not sure how we should proceed on this? Should I fix conflicts locally and push directly to master?

@yijiangh yijiangh force-pushed the yh/multi_color_visualizer branch 2 times, most recently from 4a39f86 to b495fd4 Compare February 3, 2023 16:21
@yijiangh yijiangh force-pushed the master branch 2 times, most recently from f6d9bfd to 7d7b14e Compare February 3, 2023 16:36
@yijiangh
Copy link
Collaborator Author

yijiangh commented Feb 3, 2023

Did a mega commit merge by first resetting and then rebase onto master as suggested by @mohamed82008. Ready to be merged after the checks are passed.

@mohamed82008 mohamed82008 merged commit 2b6f758 into master Feb 4, 2023
@mohamed82008
Copy link
Member

Thanks Yijiang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants