Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using a redirecting URL #181

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Avoid using a redirecting URL #181

merged 1 commit into from
Jan 23, 2019

Conversation

omus
Copy link
Member

@omus omus commented Jan 23, 2019

Should fix: #180

I believe the issue there was that using the redirecting HTTPS URL resulted in the redirection failing. For some reason using HTTP didn't have this problem though. However since "http://data.iana.org/time-zones/releases" redirects to "https://data.iana.org/time-zones/releases" I don't this using HTTP will make a difference.

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #181 into master will increase coverage by 2.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #181     +/-   ##
=========================================
+ Coverage   91.96%   94.26%   +2.3%     
=========================================
  Files          30       32      +2     
  Lines        1058     1640    +582     
=========================================
+ Hits          973     1546    +573     
- Misses         85       94      +9
Impacted Files Coverage Δ
src/tzdata/download.jl 95.08% <100%> (+3.19%) ⬆️
src/io.jl 85.36% <0%> (-1.6%) ⬇️
src/tzdata/version.jl 95.91% <0%> (-0.75%) ⬇️
src/utcoffset.jl 100% <0%> (ø) ⬆️
src/exceptions.jl 100% <0%> (ø) ⬆️
src/TimeZones.jl 100% <0%> (ø) ⬆️
src/adjusters.jl 100% <0%> (ø) ⬆️
src/conversions.jl 100% <0%> (ø) ⬆️
src/tzdata/TZData.jl 100% <0%> (ø) ⬆️
src/types.jl 95.5% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2c6ce...27674e6. Read the comment docs.

@omus omus merged commit e092a46 into master Jan 23, 2019
@omus omus deleted the cv/url-hotfix branch January 23, 2019 22:17
@omus omus restored the cv/url-hotfix branch January 23, 2019 22:18
@omus omus deleted the cv/url-hotfix branch January 23, 2019 22:20
kpamnany pushed a commit to RelationalAI-oss/TimeZones.jl that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tzdata download URL broken (currently?)
2 participants