Initial transition effective from typemin(DateTime) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
omus
added a commit
that referenced
this pull request
Oct 13, 2015
Initial transition effective from typemin(DateTime)
omus
pushed a commit
to invenia/TimeZones.jl
that referenced
this pull request
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariableTimeZone types are made up of transitions which have a UTC DateTime indicating the instant at when the new rule becomes effective. Previously the first transition started at 1800/1/1 for no real reason except that no zone or rule started that early and it is rather silly to use the concept of time zones prior to their use. After merging in #8 it seems more reasonable to allow users to make ZonedDateTime's prior to 1800 and let them use their own judgement.
As a happy side effect this makes comparing Julia processed timezone rules easier to compare with tzfiles.