-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sandbox
call on 1.11-beta
#87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
===========================================
- Coverage 73.91% 39.06% -34.85%
===========================================
Files 25 28 +3
Lines 621 709 +88
===========================================
- Hits 459 277 -182
- Misses 162 432 +270 ☔ View full report in Codecov by Sentry. |
Is this blocked on the Codecov failure? This PR just removes one of the arguments to |
Sorry no this is blocked by me not seeing it til now. Having given this some thought, |
I have updated the PR as you suggested. The new commits undo all modifications to the |
@oxinabox ready to merge now? |
@oxinabox could you maybe make me a co-maintainer of this repo so that I can merge PRs like this one? |
Gentle ping |
Sorry I was away for a bit. This needs to also add 1.10 and 1.11 to the CI matrix |
I tried naively adding 1.11 to the CI matrix. This throws an error, since 1.11 hasn't been released. How to proceed? Update: From this documentation, the correct syntax seems to be I think this PR is ready to merge. |
@oxinabox I think I still don't have write access so that I can merge things? |
I am good for this to be merged, I am going to leave it to David to actually merge because I want to check I setup his permissions right, since i failed the first time |
As a possible fix to #86, one could modify the arguments to
sandbox
at the call site, depending on a static version comparison. This would minimize code duplication by reusing the rest of the code insidesrc/julia-1.9
. In this branch, tests pass for me locally on both 1.10 and 1.11-beta.