Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on Julia master (1.4) #74

Closed
KristofferC opened this issue Jan 3, 2020 · 2 comments
Closed

Tests fail on Julia master (1.4) #74

KristofferC opened this issue Jan 3, 2020 · 2 comments

Comments

@KristofferC
Copy link
Member

The tests here starts failing immidiately on Julia master (1.4):

Mocking: Test Failed at /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/targets.jl:12
  Expression: #= /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/targets.jl:12 =# @mock(global_scope()) != global_scope()
   Evaluated: "org" != "org"
Stacktrace:
 [1] (::var"#190#191")() at /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/targets.jl:12
 [2] apply(::var"#190#191", ::Mocking.PatchEnv) at /home/pkgeval/.julia/packages/Mocking/hFQQ4/src/patch.jl:64
 [3] apply(::Function, ::Patch{typeof(global_scope)}; debug::Bool) at /home/pkgeval/.julia/packages/Mocking/hFQQ4/src/patch.jl:71
 [4] apply(::Function, ::Patch{typeof(global_scope)}) at /home/pkgeval/.julia/packages/Mocking/hFQQ4/src/patch.jl:71
 [5] top-level scope at /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/targets.jl:11
 [6] include(::String) at ./client.jl:439
 [7] macro expansion at /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/runtests.jl:16 [inlined]
 [8] macro expansion at /workspace/srcdir/usr/share/julia/stdlib/v1.4/Test/src/Test.jl:1116 [inlined]
 [9] top-level scope at /home/pkgeval/.julia/packages/Mocking/hFQQ4/test/runtests.jl:11

It would be nice if we could figure out the root cause to see if this is due to a regression in Julia.

@omus
Copy link
Member

omus commented Jan 6, 2020

I've looked into the issue and it does appear to be a Julia issue

Julia 1.3

julia> f() = 1
f (generic function with 1 method)

julia> methods(f, ())
# 1 method for generic function "f":
[1] f() in Main at REPL[1]:1

Julia 1.4

julia> f() = 1
f (generic function with 1 method)

julia> methods(f, ())
# 0 methods for generic function "f":

I'll file an issue.

@omus
Copy link
Member

omus commented Jan 8, 2020

Now fixed in the latest Julia nightly

@omus omus closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants