remove Base and Core from ambiguities test #309
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reporting ambiguities that cannot be fixed by the user since they are not part of the testtarget can be harmful to the user experience since they will never be useful, since at least JuliaLang/julia#36962. Fixes JuliaTesting#77
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
=======================================
Coverage 74.90% 74.90%
=======================================
Files 11 11
Lines 761 761
=======================================
Hits 570 570
Misses 191 191 ☔ View full report in Codecov by Sentry. |
|
Thanks @vtjnash! If this approach comes from you, I suppose there is nothing else we can do here. Would you consider this change a Bugfix (i.e. To be released in a patch release) or a larger change (I.e. to be released in a minor/breaking release)? I am thinking about this as many projects may expect these ambiguities and some @test_broken could fail now. |
|
It is a bugfix. I don't know why any project would want to fail on ambiguities that have nothing to do with their package |
lgoettgens
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting ambiguities that cannot be fixed by the user since they are not part of the testtarget can be harmful to the user experience since they will never be useful, since at least JuliaLang/julia#36962.
Fixes #77