Add kwarg succeed_on_precompilable_error
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
enhancement
lgoettgens
force-pushed
the
lg/skip_on_precompilable_error
branch
from
d6abd1e
to
08a9f4b
Compare
lgoettgens
changed the title
skip_on_precompilable_errorsucceed_on_precompilable_error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 75.03% 70.14% -4.89%
==========================================
Files 11 11
Lines 761 757 -4
==========================================
- Hits 571 531 -40
- Misses 190 226 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lgoettgens
added a commit
that referenced
this pull request
Apr 9, 2024
This reverts commit 231a1d1.
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often experience precompilable errors in development when sorting out type piracy etc., e.g. when moving functions to a dependency and thus creating method overwriting. This change let's the persistent task test succeed in the case of a precompilable error to smooth these cases, with the possibility to opt-in into getting this as a failure instead.