Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale deps stdlibs known bug warning #266

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

LilithHafner
Copy link
Contributor

I just got this error

Stale dependencies: Test Failed at /home/x/.julia/packages/Aqua/9p8ck/src/stale_deps.jl:31
  Expression: isempty(stale_deps)
   Evaluated: isempty(Base.PkgId[Base.PkgId(Base.UUID("9e88b42a-f829-5b0c-bbe9-9e923198166b"), "Serialization")])

So I think this bug is fixed.

Would tests be expected for this PR?

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (34a1a02) to head (421a0e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files          11       11           
  Lines         750      750           
=======================================
  Hits          564      564           
  Misses        186      186           
Flag Coverage Δ
unittests 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator

lgoettgens commented Mar 6, 2024

Thanks for the report!
After creating a MWE and testing with different julia versions, Serialization gets reported as a stale dep in 1.11.0-alpha1 and nightly, but not in 1.10.2.
My guess is that this is due to the removal from the sysimg (JuliaLang/julia#51399). Other stdlibs that are still in the sysimg (e.g. LinearAlgebra) still won't get detected.

Thus instead of removing the warning, I would change the "stdlib" to "package in the sysimage" or something.

@LilithHafner
Copy link
Contributor Author

I suspected that too, and even tested it to confirm. I must have made a mistake. I'll update the PR

@LilithHafner LilithHafner changed the title Delete stale deps stdlibs known bug warning Update stale deps stdlibs known bug warning Mar 6, 2024
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgoettgens lgoettgens enabled auto-merge (squash) March 6, 2024 14:58
@lgoettgens lgoettgens merged commit b51f800 into JuliaTesting:master Mar 6, 2024
21 of 25 checks passed
@LilithHafner LilithHafner deleted the patch-1 branch March 7, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants