Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for julia 1.0-1.3 #221

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Oct 24, 2023

Resolves #216, closes #195.

@lgoettgens
Copy link
Collaborator Author

@fingolfin could you please mark the ci jobs for 1.0-1.3 as no longer required?

@lgoettgens lgoettgens changed the title Drop support for julia 1.0-1.3 @lgoettgens Drop support for julia 1.0-1.3 Oct 24, 2023
@lgoettgens lgoettgens marked this pull request as ready for review October 24, 2023 12:41
@hyrodium
Copy link
Contributor

hyrodium commented Oct 24, 2023

Usually, dropping support for earlier version of Julia is not considered as breaking.

Changing Julia version compatibility must be a non-breaking feature

https://github.com/SciML/ColPrac#dropping-support-for-earlier-versions-of-julia

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #221 (0af536b) into master (7f18f15) will increase coverage by 12.63%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #221       +/-   ##
===========================================
+ Coverage   76.81%   89.45%   +12.63%     
===========================================
  Files          11       10        -1     
  Lines         772      512      -260     
===========================================
- Hits          593      458      -135     
+ Misses        179       54      -125     
Flag Coverage Δ
unittests 89.45% <100.00%> (+12.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Aqua.jl 73.07% <ø> (ø)
src/utils.jl 90.66% <100.00%> (-0.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens
Copy link
Collaborator Author

Usually, dropping support for earlier version of Julia is not considered as breaking.

Changing Julia version compatibility must be a non-breaking feature

https://github.com/SciML/ColPrac#dropping-support-for-earlier-versions-of-julia

This is true for packages with a x.y.z versioning scheme. As Aqua.jl is on version 0.y.z, I can either release this as breaking, or as a patch release. But the julia version should not be restricted on a patch release.

@lgoettgens
Copy link
Collaborator Author

And there will be more breaking changes released together with this in one batch.

Project.toml Show resolved Hide resolved
@fingolfin
Copy link
Collaborator

As requested I marked the ci jobs for 1.0-1.3 as no longer required.

@fingolfin
Copy link
Collaborator

Oh, I'll also add the new 1.4 test for Windows and macOS to the list of required tests.

@lgoettgens
Copy link
Collaborator Author

Oh, I'll also add the new 1.4 test for Windows and macOS to the list of required tests.

Can you add "enforce PR labels" as well?

@fingolfin
Copy link
Collaborator

@lgoettgens BTW you could have just restarted that one failing job, instead of restarting all :-)

@lgoettgens
Copy link
Collaborator Author

@lgoettgens BTW you could have just restarted that one failing job, instead of restarting all :-)

I know, but I wanted to make sure that this is not something failing on a small percentage of runs, and more runs would maybe find that :)

@lgoettgens
Copy link
Collaborator Author

Windows-1.4 seems to need a bit more time than 10 minutes. I tried to lengthen the timeout for windows jobs.

@lgoettgens lgoettgens enabled auto-merge (squash) October 24, 2023 13:39
@lgoettgens lgoettgens merged commit 69a7655 into JuliaTesting:master Oct 24, 2023
20 checks passed
@lgoettgens lgoettgens deleted the lg/drop-old-julias branch October 24, 2023 13:58
lgoettgens added a commit that referenced this pull request Oct 27, 2023
lgoettgens added a commit that referenced this pull request Oct 27, 2023
lgoettgens added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for julia 1.0-1.3?
3 participants