Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more CI targets #197

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add more CI targets #197

merged 1 commit into from
Sep 25, 2023

Conversation

lgoettgens
Copy link
Collaborator

Test on macos as well, as well as against julia nightly on both macos and windows to hopefully catch problems early.

@fingolfin

This comment was marked as resolved.

@lgoettgens lgoettgens changed the title Add more CI targest Add more CI targets Sep 25, 2023
Copy link
Collaborator

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course this will make CI slower. Do you think it is likely that this pure Julia package will run into errors that only occur on macOS and/or Windows?

Anyway, other than waiting a bit longer for PRs to be ready, I see no drawbacks shrug

@lgoettgens
Copy link
Collaborator Author

Of course this will make CI slower. Do you think it is likely that this pure Julia package will run into errors that only occur on macOS and/or Windows?

There e.g. was an issue only occurring on Windows with the persistent_tasks PR which led to 43cbd3a. I would therefore like some few runners of all OSes.

Anyway, other than waiting a bit longer for PRs to be ready, I see no drawbacks shrug

The JuliaTesting runners are usually not used, so that is basically negligible. (Apart from right now somehow)

@lgoettgens lgoettgens enabled auto-merge (squash) September 25, 2023 15:02
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #197 (db08942) into master (17b23d6) will increase coverage by 0.26%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   77.64%   77.91%   +0.26%     
==========================================
  Files          11       11              
  Lines         756      756              
==========================================
+ Hits          587      589       +2     
+ Misses        169      167       -2     
Flag Coverage Δ
unittests 77.91% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens lgoettgens merged commit e58c279 into JuliaTesting:master Sep 25, 2023
22 checks passed
@lgoettgens lgoettgens deleted the lg/ci branch September 25, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants