Skip to content

Commit

Permalink
Turn test_persistent_tasks on by default
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens committed Oct 24, 2023
1 parent 0dcd8bf commit 77f7fd7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Two additions check whether packages might block precompilation on Julia 1.10 or higher:
+ `test_persistent_tasks` tests whether "your" package can safely be used as a dependency for downstream packages. This test is disabled for the default testsuite, but you can opt-in by supplying `persistent_tasks=true` to `test_all`.
- Two additions check whether packages might block precompilation on Julia 1.10 or higher: ([#174](https://github.com/JuliaTesting/Aqua.jl/pull/174))
+ `test_persistent_tasks` tests whether "your" package can safely be used as a dependency for downstream packages. This test is enabled for the default testsuite, but you can opt-out by supplying `persistent_tasks=false` to `test_all`. [BREAKING]
+ `find_persistent_tasks_deps` is useful if "your" package hangs upon precompilation: it runs `test_persistent_tasks` on all the things you depend on, and may help isolate the culprit(s).

### Changed
Expand Down
4 changes: 2 additions & 2 deletions src/Aqua.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ passed to `\$x` to specify the keyword arguments for `test_\$x`.
- `deps_compat = true`
- `project_toml_formatting = true`
- `piracy = true`
- `persistent_tasks = false` (will become `true` in the next breaking release)
- `persistent_tasks = true`
"""
function test_all(
testtarget::Module;
Expand All @@ -64,7 +64,7 @@ function test_all(
deps_compat = true,
project_toml_formatting = true,
piracy = true,
persistent_tasks = false,
persistent_tasks = true,
)
@testset "Method ambiguity" begin
if ambiguities !== false
Expand Down
2 changes: 1 addition & 1 deletion test/test_smoke.jl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Aqua.test_all(
deps_compat = (; check_extras = true, check_weakdeps = true),
project_toml_formatting = false,
piracy = false,
persistent_tasks = true,
persistent_tasks = false,
)

end # module

0 comments on commit 77f7fd7

Please sign in to comment.