Skip to content

Commit

Permalink
Print module in test_undefined_exports report (#177)
Browse files Browse the repository at this point in the history
* Add test

* Print module in undefined export report
  • Loading branch information
lgoettgens authored Sep 18, 2023
1 parent e5145d3 commit 275e71e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/exports.jl
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function undefined_exports(m::Module)
undefined = Symbol[]
walkmodules(m) do x
for n in names(x)
isdefined(x, n) || push!(undefined, n)
isdefined(x, n) || push!(undefined, Symbol(join([fullname(x)...; n], '.')))
end
end
return undefined
Expand Down
2 changes: 2 additions & 0 deletions test/test_undefined_exports.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ include("preamble.jl")
using PkgWithUndefinedExports

@testset begin
@test Aqua.undefined_exports(PkgWithUndefinedExports) ==
[Symbol("PkgWithUndefinedExports.undefined_name")]
results = @testtestset begin
Aqua.test_undefined_exports(PkgWithUndefinedExports)
end
Expand Down

0 comments on commit 275e71e

Please sign in to comment.